[fix](cloud) Fix group commit routing for virtual compute groups - #66585
Open
Yukang-Lian wants to merge 1 commit into
Open
[fix](cloud) Fix group commit routing for virtual compute groups#66585Yukang-Lian wants to merge 1 commit into
Yukang-Lian wants to merge 1 commit into
Conversation
### What problem does this PR solve? Issue Number: None Related PR: apache#61555 Problem Summary: Group commit resolves a virtual compute group when collecting backend candidates, but previously validated and cached those backends with the original virtual name. Since backends carry the physical compute group name, every healthy candidate was rejected. Resolve the physical compute group once on the master and use it consistently for cache lookup, candidate selection, and membership validation. ### Release note Fix group commit stream loads through virtual compute groups. ### Check List (For Author) - Test - [x] Unit Test - [ ] Regression test (VCG Docker coverage added and loaded locally; the Docker cluster was not run locally) - Behavior changed: - [x] Yes. Group commit requests through a virtual compute group now route to its active physical compute group. - Does this need documentation? - [x] No.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Yukang-Lian
marked this pull request as ready for review
August 7, 2026 13:59
Collaborator
Author
|
/review |
Contributor
|
Codex automated review failed and did not complete. Error: All Codex review accounts are usage-limited; earliest retry is 2026-08-08T03:32:00Z. Please trigger /review again after that time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: #61555
Problem Summary:
Group commit resolves a virtual compute group to its active physical compute group when collecting backend candidates. However, it previously used the original virtual name for the backend cache and membership validation. Because each backend carries its physical compute group name, all healthy candidates were rejected and group commit stream loads failed with
No suitable backend.This change resolves the physical compute group once on the master and consistently uses that request-level snapshot for cache lookup, candidate selection, and backend membership validation. A failover therefore uses a separate physical-group cache key and cannot reuse a backend from the previous active group.
The existing VCG Docker suite now enables synchronous group commit before and after failover and explicitly exercises both the master HTTP path and follower-to-master forwarding path.
Release note
Fix group commit stream loads through virtual compute groups.
Check List (For Author)
Test
Validation performed:
./run-fe-ut.sh --run org.apache.doris.load.GroupCommitManagerTest(2 tests, 0 failures, 0 errors)excludeDockerTest=true; CI is expected to run the actual cloud cluster scenario.Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)