branch-4.0: [fix](fe) Select S3 storage for cloud plugin downloads - #66694
Open
CalvinKirs wants to merge 1 commit into
Open
branch-4.0: [fix](fe) Select S3 storage for cloud plugin downloads#66694CalvinKirs wants to merge 1 commit into
CalvinKirs wants to merge 1 commit into
Conversation
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: In Cloud SaaS mode, a JDBC catalog with a bare driver jar name downloads the driver from the instance object store. StorageProperties.createAll now prepends a default HDFS entry, so CloudPluginDownloader selected that first entry and cast it to AbstractS3CompatibleProperties, causing a ClassCastException before the download. Select the first explicitly S3-compatible property by type and pass the typed result to S3ObjStorage. Add coverage for the default-HDFS ordering, every current S3-compatible implementation, and the missing-compatible-storage failure.
### Release note
Fix automatic JDBC driver and Java UDF jar downloads from Cloud SaaS object storage when the plugin is referenced by a bare file name.
### Check List (For Author)
- Test: Unit Test (environment blocked)
- `MAVEN_OPTS="-Xmx4g -XX:MaxMetaspaceSize=1g" FE_UT_PARALLEL=1 ./run-fe-ut.sh --run org.apache.doris.common.plugin.CloudPluginDownloaderTest` completed Checkstyle, FE main compilation, and test compilation; all 9 tests were blocked in the existing Mockito setup because Byte Buddy cannot self-attach in the execution sandbox
- Behavior changed: Yes (Cloud SaaS plugin downloads select S3-compatible storage instead of the prepended default HDFS entry)
- Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
CalvinKirs
changed the title
Member
Author
|
run buildall |
CalvinKirs
marked this pull request as ready for review
August 12, 2026 10:18
Member
Author
|
run feut |
Member
Author
|
run p0 |
Contributor
FE Regression Coverage ReportIncrement line coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Problem Summary: In Cloud SaaS mode, a JDBC catalog or Java UDF using a bare jar name downloads the file from the instance object store.
StorageProperties.createAll()now prepends a default HDFS entry, whileCloudPluginDownloaderselected the first entry and cast it toAbstractS3CompatibleProperties. The cast therefore failed withClassCastExceptionbefore the download. This change selects the first explicitly S3-compatible property by type and fails clearly if none exists. Tests cover default-HDFS ordering, all current S3-compatible property implementations, and the missing-compatible-storage path.Release note
Fix automatic JDBC driver and Java UDF jar downloads from Cloud SaaS object storage when the plugin is referenced by a bare file name.
Check List (For Author)
MAVEN_OPTS="-Xmx4g -XX:MaxMetaspaceSize=1g" FE_UT_PARALLEL=1 ./run-fe-ut.sh --run org.apache.doris.common.plugin.CloudPluginDownloaderTestcompleted Checkstyle, FE main compilation, and test compilation. All 9 tests were blocked in the existing Mockito setup because Byte Buddy cannot self-attach in the execution sandbox; there were no assertion failures.