Skip to content

branch-4.1: [fix](be) Skip file cache for http chunk-response readers #66932 - #67190

Merged
yiguolei merged 1 commit into
branch-4.1from
auto-pick-66932-branch-4.1
Aug 27, 2026
Merged

branch-4.1: [fix](be) Skip file cache for http chunk-response readers #66932#67190
yiguolei merged 1 commit into
branch-4.1from
auto-pick-66932-branch-4.1

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Cherry-picked from #66932

### What problem does this PR solve?

Issue Number: None

Related PR: None

Problem Summary:

The file-block cache assumes that a reader exposes stable, random-access
content. HTTP readers used by CDC TVF chunk responses instead expose a
dynamic streaming response. When file cache is enabled, wrapping such a
reader with `CachedRemoteFileReader` can make the stream appear empty or
reuse invalid cached content.

This change adds a reader capability check and skips the file-cache
wrapper for HTTP chunk-response readers. Other HTTP file readers
continue using the existing cache path. A unit test covers the bypass
behavior.
@github-actions
github-actions Bot requested a review from yiguolei as a code owner August 27, 2026 03:42
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen

Copy link
Copy Markdown
Contributor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 100.00% (9/9) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 59.40% (25633/43155)
Line Coverage 43.88% (261876/596868)
Region Coverage 39.81% (207462/521076)
Branch Coverage 41.30% (95699/231697)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (9/9) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 74.12% (31164/42048)
Line Coverage 58.27% (345191/592376)
Region Coverage 54.99% (287222/522355)
Branch Coverage 55.92% (129418/231431)

@yiguolei
yiguolei merged commit 816d0f8 into branch-4.1 Aug 27, 2026
30 of 32 checks passed
@github-actions

Copy link
Copy Markdown
Contributor Author

PR approved by anyone and no changes requested.

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Aug 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor Author

PR approved by at least one committer and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants