[fix](function) Support bracketed IPv6 in parse_url - #67382
Open
Mryange wants to merge 1 commit into
Open
Conversation
### What problem does this PR solve? Issue Number: N/A Problem Summary: parse_url treated every colon in a bracketed IPv6 literal as a port separator, so HOST and PORT returned incorrect values. Recognize the closing bracket as the IPv6 host boundary in both FE constant folding and BE execution. ### Release note Support extracting HOST and PORT from URLs containing bracketed IPv6 literals. ### Check List (For Author) - Test: Regression test / Unit Test / Manual test - Behavior changed: Yes. parse_url now handles bracketed IPv6 hosts. - Does this need documentation: No
Mryange
requested review from
924060929,
englefly,
morrySnow and
starocean999
as code owners
September 1, 2026 10:12
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Summary:
parse_urltreated colons inside bracketed IPv6 literals as port separators, producing incorrectHOSTandPORTresults. The FE constant-folding and BE execution paths now recognize the closing bracket as the host boundary and only parse a port after]:.Release note
Support extracting
HOSTandPORTfrom URLs containing bracketed IPv6 literals.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)