Skip to content

[refactor](nereids) Remove minidump, plan replayer, and tracing - #67811

Open
morrySnow wants to merge 1 commit into
apache:masterfrom
morrySnow:codex/remove-minidump-plan-replayer-nereids-trace
Open

[refactor](nereids) Remove minidump, plan replayer, and tracing#67811
morrySnow wants to merge 1 commit into
apache:masterfrom
morrySnow:codex/remove-minidump-plan-replayer-nereids-trace

Conversation

@morrySnow

@morrySnow morrySnow commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: None

Related PR: #66817

Problem Summary:

The remaining minidump dump path and Nereids trace framework are no longer needed after offline plan replay was removed. Remove PLAN REPLAYER DUMP and its REST endpoint, minidump serialization, replay-only statistics and context plumbing, the enable_nereids_trace variables, and the event tracing implementation. Also remove replay-specific privilege and row-policy bypasses so normal planning always uses catalog statistics and standard authorization paths.

Release note

Remove PLAN REPLAYER DUMP, the /api/minidump endpoint, and the enable_nereids_trace and nereids_trace_event_mode session variables.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
      • ./run-fe-ut.sh --run org.apache.doris.nereids.parser.NereidsParserTest,org.apache.doris.nereids.rules.analysis.UserAuthenticationTest (94 tests)
    • Manual test
    • No need to test or manual test
  • Behavior changed:

    • No.
    • Yes. Remove the minidump, plan replayer dump, and Nereids trace interfaces.
  • Does this need documentation?

    • No. These developer-only interfaces are not documented.
    • Yes.

### What problem does this PR solve?

Issue Number: None

Related PR: apache#66817

Problem Summary:

The remaining minidump dump path and Nereids trace framework are no longer needed after offline plan replay was removed. Remove PLAN REPLAYER DUMP and its REST endpoint, minidump serialization, replay-only statistics and context plumbing, the enable_nereids_trace variables, and the event tracing implementation. Also remove replay-specific privilege and row-policy bypasses so normal planning always uses catalog statistics and standard authorization paths.

### Release note

Remove `PLAN REPLAYER DUMP`, the `/api/minidump` endpoint, and the `enable_nereids_trace` and `nereids_trace_event_mode` session variables.

### Check List (For Author)

- Test
    - [ ] Regression test
    - [x] Unit Test
        - `NereidsParserTest`
        - `UserAuthenticationTest`
    - [ ] Manual test
    - [ ] No need to test or manual test

- Behavior changed:
    - [ ] No.
    - [x] Yes. Remove the minidump, plan replayer dump, and Nereids trace interfaces.

- Does this need documentation?
    - [x] No. These developer-only interfaces are not documented.
    - [ ] Yes.
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow morrySnow changed the title [refactor](nereids) Remove minidump and Nereids tracing [refactor](nereids) Remove minidump, plan replayer, and tracing Sep 10, 2026
@morrySnow

Copy link
Copy Markdown
Contributor Author

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 26.67% (8/30) 🎉
Increment coverage report
Complete coverage report

@924060929 924060929 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed at a5bb3aa. The removal is cohesive: parser/command and REST entry points, session/config state, replay-only authorization and statistics branches, and tracing hooks are removed consistently. I found no remaining references or behavioral changes outside the retired interfaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants