[refactor](nereids) Remove minidump, plan replayer, and tracing - #67811
Open
morrySnow wants to merge 1 commit into
Open
[refactor](nereids) Remove minidump, plan replayer, and tracing#67811morrySnow wants to merge 1 commit into
morrySnow wants to merge 1 commit into
Conversation
### What problem does this PR solve? Issue Number: None Related PR: apache#66817 Problem Summary: The remaining minidump dump path and Nereids trace framework are no longer needed after offline plan replay was removed. Remove PLAN REPLAYER DUMP and its REST endpoint, minidump serialization, replay-only statistics and context plumbing, the enable_nereids_trace variables, and the event tracing implementation. Also remove replay-specific privilege and row-policy bypasses so normal planning always uses catalog statistics and standard authorization paths. ### Release note Remove `PLAN REPLAYER DUMP`, the `/api/minidump` endpoint, and the `enable_nereids_trace` and `nereids_trace_event_mode` session variables. ### Check List (For Author) - Test - [ ] Regression test - [x] Unit Test - `NereidsParserTest` - `UserAuthenticationTest` - [ ] Manual test - [ ] No need to test or manual test - Behavior changed: - [ ] No. - [x] Yes. Remove the minidump, plan replayer dump, and Nereids trace interfaces. - Does this need documentation? - [x] No. These developer-only interfaces are not documented. - [ ] Yes.
morrySnow
requested review from
924060929,
englefly and
starocean999
as code owners
September 10, 2026 11:40
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
Contributor
FE UT Coverage ReportIncrement line coverage |
924060929
approved these changes
Sep 12, 2026
924060929
left a comment
Contributor
There was a problem hiding this comment.
Reviewed at a5bb3aa. The removal is cohesive: parser/command and REST entry points, session/config state, replay-only authorization and statistics branches, and tracing hooks are removed consistently. I found no remaining references or behavioral changes outside the retired interfaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: None
Related PR: #66817
Problem Summary:
The remaining minidump dump path and Nereids trace framework are no longer needed after offline plan replay was removed. Remove
PLAN REPLAYER DUMPand its REST endpoint, minidump serialization, replay-only statistics and context plumbing, theenable_nereids_tracevariables, and the event tracing implementation. Also remove replay-specific privilege and row-policy bypasses so normal planning always uses catalog statistics and standard authorization paths.Release note
Remove
PLAN REPLAYER DUMP, the/api/minidumpendpoint, and theenable_nereids_traceandnereids_trace_event_modesession variables.Check List (For Author)
Test
./run-fe-ut.sh --run org.apache.doris.nereids.parser.NereidsParserTest,org.apache.doris.nereids.rules.analysis.UserAuthenticationTest(94 tests)Behavior changed:
Does this need documentation?