Skip to content

fixes possible data truncation#11462

Merged
asdf2014 merged 3 commits intoapache:masterfrom
isandeep41:fix-possible-data-truncation
Aug 26, 2021
Merged

fixes possible data truncation#11462
asdf2014 merged 3 commits intoapache:masterfrom
isandeep41:fix-possible-data-truncation

Conversation

@isandeep41
Copy link
Contributor

@isandeep41 isandeep41 commented Jul 18, 2021

Fixes #11461


This PR has:

  • been self-reviewed.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • been tested in a test Druid cluster.

@lgtm-com
Copy link

lgtm-com bot commented Jul 18, 2021

This pull request fixes 1 alert when merging aabed1c into 8729b40 - view on LGTM.com

fixed alerts:

  • 1 for User-controlled data in numeric cast

@asdf2014 asdf2014 added the Bug label Jul 19, 2021
Copy link
Member

@asdf2014 asdf2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@lgtm-com
Copy link

lgtm-com bot commented Jul 19, 2021

This pull request fixes 1 alert when merging b0554b6 into 8729b40 - view on LGTM.com

fixed alerts:

  • 1 for User-controlled data in numeric cast

@suneet-s
Copy link
Contributor

@isandeep41 I see you marked integration tests have been added for this PR, but I don't see any in the delta. Have you been able to reproduce this scenario locally? What would it take to make this a test that shows the problem before your fix?

@isandeep41
Copy link
Contributor Author

@suneet-s @asdf2014 I have added a unit test to catch the possible data truncation.

@lgtm-com
Copy link

lgtm-com bot commented Jul 21, 2021

This pull request fixes 1 alert when merging 7dd5faf into 167c452 - view on LGTM.com

fixed alerts:

  • 1 for User-controlled data in numeric cast

@isandeep41
Copy link
Contributor Author

@suneet-s I have updated the PR description, let me know if this looks good to you now

Copy link
Member

@FrankChen021 FrankChen021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍. Since most of subclasses of UnivariateMathFunction overrides the eval(double) implementation, this change won't change the behaviors of these classes.

@asdf2014 asdf2014 merged commit ac2b65e into apache:master Aug 26, 2021
@clintropolis clintropolis added this to the 0.22.0 milestone Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

possible data truncation

5 participants