fixes possible data truncation#11462
Conversation
|
This pull request fixes 1 alert when merging aabed1c into 8729b40 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 1 alert when merging b0554b6 into 8729b40 - view on LGTM.com fixed alerts:
|
|
@isandeep41 I see you marked integration tests have been added for this PR, but I don't see any in the delta. Have you been able to reproduce this scenario locally? What would it take to make this a test that shows the problem before your fix? |
|
This pull request fixes 1 alert when merging 7dd5faf into 167c452 - view on LGTM.com fixed alerts:
|
|
@suneet-s I have updated the PR description, let me know if this looks good to you now |
FrankChen021
left a comment
There was a problem hiding this comment.
👍. Since most of subclasses of UnivariateMathFunction overrides the eval(double) implementation, this change won't change the behaviors of these classes.
Fixes #11461
This PR has: