complex metrics -> complex types#12378
Closed
clintropolis wants to merge 4 commits intoapache:masterfrom
Closed
Conversation
changes: * rebrand ComplexMetricSerde as ComplexTypeSerde, ComplexMetrics as ComplexTypes, ComplexMetricExtractor as ComplexTypeExtractor * add 'coerceValue' method to ComplexTypeExtractor to use to allow COMPLEX types to coerce values to the appropriate type when read from a column value selector from RowBasedColumnSelectorFactory
|
This pull request introduces 1 alert when merging 1564c67 into f1841c6 - view on LGTM.com new alerts:
|
Member
Author
|
btw, I tested that this change is minimally disruptive by doing some tests using extensions (datasketches specifically, for my complex types) built against the master branch without the changes in this PR, and everything was still functioning correctly as far as I can tell, so I think it should be relatively chill despite changing stuff marked |
Member
Author
|
closing in favor of #12382, since need to think a bit more about how to do type coercion for complex dimensions (which cannot lean on agg deserialize or extractor methods to ensure that complex types are their intermediary working java type) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR rebrands
ComplexMetricSerdeasComplexTypeSerde,ComplexMetricsasComplexTypes, andComplexMetricExtractorasComplexTypeExtractor. All of the former are marked as deprecated, and their logic moved to (and implement) the latter to minimize disruption. All current serdes still implementComplexMetricSerderather than the new type, to allow anything usingComplexMetrics.getSerdeForTypeto continue functioning until their future removal, at which point the implementations shall be moved to extendComplexTypeSerdedirectly.Additionally, it adds a method to
ComplexTypeExtractor,coerceValue, to use to allowCOMPLEXtypes to coerce values to the appropriate type when read from a column value selector fromRowBasedColumnSelectorFactory. This allowsCOMPLEXtyped dimensions to perform value coercion, similar to the other use of theextractValuemethod when readingCOMPLEXmetrics for queries againstIncrementalIndex.This PR has: