feat: ensure statusCode is included in router logs#19668
Merged
Conversation
kfaraz
approved these changes
Jul 9, 2026
| int metricStatusCode | ||
| ) throws IOException | ||
| { | ||
| if (isSqlQuery) { |
Contributor
There was a problem hiding this comment.
Seems like this method is always being called for SQL queries only.
FrankChen021
reviewed
Jul 9, 2026
FrankChen021
left a comment
FrankChen021
left a comment
Member
There was a problem hiding this comment.
I have reviewed the code for correctness, edge cases, concurrency, and integration risks; no issues found.
Reviewed 2 of 2 changed files.
This is an automated review by Codex GPT-5.5
FrankChen021
left a comment
FrankChen021
left a comment
Member
There was a problem hiding this comment.
I have reviewed the updated code for correctness, edge cases, concurrency, and integration risks; no new issues found.
Reviewed 2 of 2 changed files.
This is an automated review by Codex GPT-5.6-Sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We rely on query logs for observability, operations. Currently the only source of query status code on the router is in the metric emitted by the router. We should make sure it's emitted as part of the query log as well.
Release note
Ensures that the statusCode dimension is included in router logs for better historical analysis.
This PR has: