feat: partial load rule announcement#19682
Open
clintropolis wants to merge 1 commit into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+266
to
+270
| final long fullSize = Long.parseLong( | ||
| cluster.callApi().runSql( | ||
| "SELECT \"size\" FROM sys.segments WHERE datasource = '" + dataSource + "'" | ||
| ).trim() | ||
| ); |
Comment on lines
+273
to
+277
| final long currSize = Long.parseLong( | ||
| cluster.callApi().runSql( | ||
| "SELECT curr_size FROM sys.servers WHERE server_type = 'historical'" | ||
| ).trim() | ||
| ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #19671, adds the wiring for partial loaded segments from partial load rules to announce the partially loaded size instead of the full segment size, so that the coordinator side accounting can more accurately manage cache placement. The main change is that
SegmentCacheManagerload and bootstrap methods now return aDataSegmentwhich implementations can use to thread aDataSegmentAndLoadProfileto the announcer to do the partial announcement (same type used coordinator side to carry non-serializing 'side-car' information about partial load stuff)