Skip to content

feat: upgrade to JDK 25 compiler#19707

Merged
jtuglu1 merged 7 commits into
apache:masterfrom
jtuglu1:upgrade-to-jdk-25-compiler
Jul 21, 2026
Merged

feat: upgrade to JDK 25 compiler#19707
jtuglu1 merged 7 commits into
apache:masterfrom
jtuglu1:upgrade-to-jdk-25-compiler

Conversation

@jtuglu1

@jtuglu1 jtuglu1 commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Description

Upgrade to JDK 25 compiler for Druid v39 release per https://lists.apache.org/thread/vmszj1qfr1gkqy3bfqm7n4qdxp0hy390.

Release note

Upgrade to JDK 25 compiler and drop runtime support for JDK 21.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@jtuglu1
jtuglu1 force-pushed the upgrade-to-jdk-25-compiler branch from c65cc54 to bea7472 Compare July 20, 2026 18:40
@github-actions github-actions Bot added the GHA label Jul 20, 2026
@cryptoe

cryptoe commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

JDK 25 ❤️
Thank you Jesse for driving this. !!

@jtuglu1
jtuglu1 marked this pull request as ready for review July 20, 2026 21:17
@jtuglu1
jtuglu1 force-pushed the upgrade-to-jdk-25-compiler branch from 547629a to 4516e7f Compare July 20, 2026 21:25
@jtuglu1
jtuglu1 requested a review from cryptoe July 20, 2026 23:39

@kfaraz kfaraz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Probably best to get another approval though, just in case I have missed anything.

@FrankChen021 FrankChen021 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Severity Findings
P0 0
P1 2
P2 0
P3 0
Total 2
Severity Findings
P0 0
P1 2
P2 0
P3 0
Total 2

Reviewed 10 of 10 changed files.


This is an automated review by Codex GPT-5.6-Sol

Comment thread pom.xml
Comment thread .github/workflows/ci.yml
@jtuglu1
jtuglu1 merged commit 704baa2 into apache:master Jul 21, 2026
44 of 45 checks passed
@github-actions github-actions Bot added this to the 39.0.0 milestone Jul 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants