fix: Restore respect for druid configs controlling s3 multipart upload configs - #19890
Merged
Merged
Conversation
capistrant
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| { | ||
| final String unquoted = StringUtils.replace(eTag, "\"", ""); | ||
| final int dash = unquoted.lastIndexOf('-'); | ||
| return dash < 0 ? 1 : Integer.parseInt(unquoted.substring(dash + 1)); |
capistrant
changed the title
gianm
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a regression in that we were not honoring our s3 client defaults for multipart uploads + not honoring any operator override. Without this change we use multipart but use the sdk default which appears to be 8MB chunks instead of our default of 20.
I have personally felt this impact during MSQ compaction with s3 throttling during the segment pushing at the end of a task. In investigating, I noticed that even if I tried to modify the configs, they were not being honored by the client.
Release note
Fixes a regression that was preventing s3 multipart upload configs from taking effect.
Key changed/added classes in this PR
ServerSideEncryptingAmazonS3.javaThis PR has: