Skip to content

add config values for GCS deep storage#5875

Merged
fjy merged 2 commits intoapache:masterfrom
Caroline1000:gcs-0611
Jul 5, 2018
Merged

add config values for GCS deep storage#5875
fjy merged 2 commits intoapache:masterfrom
Caroline1000:gcs-0611

Conversation

@Caroline1000
Copy link
Contributor

No description provided.


### Configuration

|Property|Possible Values|Description|Default|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we already have a document for this. Please check http://druid.io/docs/latest/development/extensions-core/hdfs.html#google-cloud-storage.

The removed configurations are actually valid when directly using GCS without Hadoop.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have two extensions that enable using GCS in deep storage: ../extensions-contrib/google.md and ../extensions-core/hdfs.html. When using the google extension, the druid.storage.type needs to be google, which isn't documented anywhere as far as I know. I was hoping to make it more clear how to use GCS with either this extension or the hdfs extension.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I got your point.

druid.storage.type should be specified as you said. But, druid.storage.storageDirectory is used only in HDFS or local deep storage types. GCS deep storage type needs to set druid.google.bucket and druid.google.prefix instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay. Thanks, Jihoon!

Copy link
Contributor

@jihoonson jihoonson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@stevenchen3
Copy link

It needs the following environment variable for authentication as well. It bugs me a bit at the beginning. We might need to clearly document it as well.

export GOOGLE_APPLICATION_CREDENTIALS=/path/to/keyfile

@fjy fjy merged commit ee4a5aa into apache:master Jul 5, 2018
@jihoonson
Copy link
Contributor

@stevenchen3 thanks. Are you interested in making a PR for that?

@Caroline1000 Caroline1000 deleted the gcs-0611 branch July 25, 2018 20:27
@dclim dclim added this to the 0.13.0 milestone Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants