Skip to content

[Extensions][Google] Add details about the keyfile#9209

Merged
jihoonson merged 1 commit intoapache:masterfrom
prabcs:gcp-secret-ingredient-in-docs
Jan 17, 2020
Merged

[Extensions][Google] Add details about the keyfile#9209
jihoonson merged 1 commit intoapache:masterfrom
prabcs:gcp-secret-ingredient-in-docs

Conversation

@prabcs
Copy link
Contributor

@prabcs prabcs commented Jan 17, 2020

Description

Setting up Druid on GCP needs druid processes to start with GOOGLE_APPLICATION_CREDENTIALS=<path to service account key file> in the environment.
After learning this the hard way, this PR adds this detail to the docs.

Also, this seems to be a backlog from #5875 (comment)


This PR has:

  • been self-reviewed.
  • been tested in a test Druid cluster.

@prabcs prabcs requested a review from jon-wei January 17, 2020 15:25


To use this Apache Druid extension, make sure to [include](../../development/extensions.md#loading-extensions) `druid-google-extensions` extension.
To use this Apache Druid extension, make sure to [include](../../development/extensions.md#loading-extensions) `druid-google-extensions` extension and run druid processes with `GOOGLE_APPLICATION_CREDENTIALS=/path/to/service_account_keyfile` in the environment.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question to reviewers: Do all druid processes need this or just the ones that are talking to GCS ??

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can set it for ones only who talk to GCS which are middleManagers, indexers, and historicals. But I guess setting this in all nodes doesn't harm as well.

@prabcs prabcs requested review from gianm and jihoonson January 17, 2020 15:38
Copy link
Contributor

@jihoonson jihoonson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prabcs thank you for the contribution! The PR looks good to me. TC failure doesn't seem legit.



To use this Apache Druid extension, make sure to [include](../../development/extensions.md#loading-extensions) `druid-google-extensions` extension.
To use this Apache Druid extension, make sure to [include](../../development/extensions.md#loading-extensions) `druid-google-extensions` extension and run druid processes with `GOOGLE_APPLICATION_CREDENTIALS=/path/to/service_account_keyfile` in the environment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can set it for ones only who talk to GCS which are middleManagers, indexers, and historicals. But I guess setting this in all nodes doesn't harm as well.

@jihoonson jihoonson merged commit 936b9bd into apache:master Jan 17, 2020
@prabcs prabcs deleted the gcp-secret-ingredient-in-docs branch January 21, 2020 17:17
@jihoonson jihoonson added this to the 0.18.0 milestone Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants