Web console: Estimate rollup ratio for a datasource#8727
Web console: Estimate rollup ratio for a datasource#8727renevan10 wants to merge 24 commits intoapache:masterfrom
Conversation
|
@renevan10 this supporting arbitrarily selecting multiple columns to exclude right? |
|
@fjy yes! You can select multiple columns. |
|
This pull request introduces 2 alerts when merging 8298a79b8ec8a4983625302225618f767cd5b68a into a8b674e - view on LGTM.com new alerts:
|
|
@renevan10 @vogievetsky does the algorithm only look at the first 20 rolls? I don't think that is going to accurately estimate the rollup ratio |
|
@fjy No it will calculate the ratio for the entire datasource based on the interval, the first 20 rows is just to serve as a preview for the user to look at. |
What happens if the interval covers a lot of data? |
|
I think you are missing a snapshot test here |
|
@fjy I think if there is a lot of data for the selected interval then the tool will be slow. It should probably mention it in the blurb |
Uh... it seems like we should think about this more. |
|
@fjy what do you mean? |
|
FYI this view is powered by a |
2f3c8c1 to
70a078a
Compare
70a078a to
3b56f95
Compare
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions. |
|
This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
This PR adds a dialog to preview and estimate rollup of a datasource under the datasources section. The top 20 rows of the datasource will be previewed. The user may get the estimated rollup ratio by:
If the ingested data was previously rolled up, the original rollup ratio will also be displayed.
Note that you must leave at least one column de-selected for the calculation.