chore:upgrade optel package - #2898
Merged
Merged
Conversation
|
Member
|
Why choose v1.21.0 instead of a higher version, with the current highest version being v1.36.0? |
AlexStocks
approved these changes
May 27, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the OpenTelemetry (otel) packages to v1.21.0 and applies consistent import formatting across several modules.
- Bump
go.opentelemetry.io/oteland related exporters to v1.21.0, along with other dependency upgrades ingo.mod. - Standardize import grouping and blank-line formatting in various
.gofiles. - Remove an inline comment explaining the side-effect import of logrus in
config_loader.go.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/dubbogo-cli/cmd/show.go | Added blank line for import grouping |
| protocol/triple/triple_protocol/server.go | Consolidated imports and adjusted blank lines |
| protocol/triple/server.go | Reordered imports and added blank-line spacing |
| protocol/dubbo/impl/hessian_test.go | Added blank line between imports |
| logger/core/zap/zap.go | Added blank line for grouping imports |
| logger/core/logrus/logrus.go | Added blank line for grouping imports |
| logger/base.go | Added blank line for grouping imports |
| go.mod | Upgraded various dependencies (otel, grpc, etc.) |
| config/config_loader.go | Removed comment explaining side-effect import |
Comments suppressed due to low confidence (1)
config/config_loader.go:32
- Re-add a comment explaining that the logrus import is only for its init-side effects; otherwise future maintainers may remove this import unintentionally.
_ "dubbo.apache.org/dubbo-go/v3/logger/core/logrus"
Member
Author
1.21.0 version can eliminate this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1.upgrade otel package to v1.21.0
2.format import style
related issues:
#2889
#2733