Skip to content

chore(triple): clean up draft TODOs and unify comment style - #3607

Merged
Alanxtl merged 1 commit into
apache:developfrom
lizining1231:chore/issue-3598-unify-triple-comments
Aug 7, 2026
Merged

chore(triple): clean up draft TODOs and unify comment style#3607
Alanxtl merged 1 commit into
apache:developfrom
lizining1231:chore/issue-3598-unify-triple-comments

Conversation

@lizining1231

Copy link
Copy Markdown

Description

Fixes #3598 (task 24)
Unify the comment style in the Triple mainline( protocol/triple/client.go , protocol/triple/server.go ,
protocol/triple/triple_protocol/handler.go ). This is a comment-only change with no behavior impact.

Changes

  • Remove stale and duplicate draft TODOs: two dangling client TODOs
    (already implemented), a duplicated opentracing TODO, and a TODO
    referencing the non-existent handleService.
  • Fix a malformed TODO: // todo:// open tracing -> // TODO: support OpenTracing.
  • Rewrite the "Enrich http2/http3 transport config" TODOs into real transport config descriptions.
  • Comment capitalization: capitalize the first letter of inline comments
    (including end-of-line comments) across the three files.
  • TODO capitalization: normalize todo to all-caps TODO with a colon,
    keeping author tags (e.g. TODO(DMwangnima):).
  • Term capitalization: idl -> IDL, tls -> TLS, opentracing -> OpenTracing.
  • Comment formatting fixes: missing space after //,
    tailer -> trailer typo, and consistent Compatibility: notes.

Checklist

  • I confirm the target branch is develop
  • Code has passed local testing
  • I have added tests that prove my fix is effective or that my feature works

…iple link

Remove stale and duplicate draft TODOs, fix malformed ones, and turn vague
"Enrich transport config" TODOs into real descriptions. Unify inline comment
style in the Triple mainline: idl->IDL, capitalized first letters for inline
comments, TODO in all caps with a colon, and consistent Compatibility notes.

Signed-off-by: lizining <lizining1231@outlook.com>
@sonarqubecloud

sonarqubecloud Bot commented Aug 6, 2026

Copy link
Copy Markdown

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.87%. Comparing base (48d6e69) to head (a89c3f2).
⚠️ Report is 8 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3607      +/-   ##
===========================================
- Coverage    54.57%   53.87%   -0.71%     
===========================================
  Files          460      474      +14     
  Lines        35443    36388     +945     
===========================================
+ Hits         19344    19604     +260     
- Misses       14543    15207     +664     
- Partials      1556     1577      +21     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lizining1231

Copy link
Copy Markdown
Author
image All CI failures are "Set up job" errors due to the recent GitHub Actions outage, unrelated to this PR. Could someone please re-run the workflows? Thanks!

@Alanxtl Alanxtl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Alanxtl Alanxtl linked an issue Aug 7, 2026 that may be closed by this pull request
@Alanxtl Alanxtl added 📒 Documentation issues with documentations 3.3.3 version 3.3.3 labels Aug 7, 2026
@Alanxtl Alanxtl self-assigned this Aug 7, 2026
@Alanxtl
Alanxtl merged commit 0d06f3b into apache:develop Aug 7, 2026
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.3.3 version 3.3.3 📒 Documentation issues with documentations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[OSPP] 完善 Dubbo-Go SDK 文档与 dubbo-go 入门任务

3 participants