chore(triple): clean up draft TODOs and unify comment style - #3607
Merged
Alanxtl merged 1 commit intoAug 7, 2026
Merged
Conversation
…iple link Remove stale and duplicate draft TODOs, fix malformed ones, and turn vague "Enrich transport config" TODOs into real descriptions. Unify inline comment style in the Triple mainline: idl->IDL, capitalized first letters for inline comments, TODO in all caps with a colon, and consistent Compatibility notes. Signed-off-by: lizining <lizining1231@outlook.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3607 +/- ##
===========================================
- Coverage 54.57% 53.87% -0.71%
===========================================
Files 460 474 +14
Lines 35443 36388 +945
===========================================
+ Hits 19344 19604 +260
- Misses 14543 15207 +664
- Partials 1556 1577 +21 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
Fixes #3598 (task 24)
Unify the comment style in the Triple mainline( protocol/triple/client.go , protocol/triple/server.go ,
protocol/triple/triple_protocol/handler.go ). This is a comment-only change with no behavior impact.
Changes
(already implemented), a duplicated opentracing TODO, and a TODO
referencing the non-existent handleService.
(including end-of-line comments) across the three files.
keeping author tags (e.g. TODO(DMwangnima):).
tailer -> trailer typo, and consistent Compatibility: notes.
Checklist
develop