Skip to content

Update cache moudle jdk17 and springboot3 #1055

Merged
AlbumenJ merged 7 commits intoapache:masterfrom
3424672656:update_cache_version
Mar 14, 2024
Merged

Update cache moudle jdk17 and springboot3 #1055
AlbumenJ merged 7 commits intoapache:masterfrom
3424672656:update_cache_version

Conversation

@3424672656
Copy link
Copy Markdown
Contributor

@3424672656 3424672656 commented Mar 12, 2024

upgrade jdk17 and springboot3.2.0 and add missing annotation

@3424672656
Copy link
Copy Markdown
Contributor Author

3424672656 commented Mar 12, 2024

It's already running locally

AlbumenJ
AlbumenJ requested changes Mar 13, 2024
View reviewed changes
Comment thread 2-advanced/dubbo-samples-cache/pom.xml
Comment thread 2-advanced/dubbo-samples-cache/pom.xml Outdated
<dubbo.version>3.2.6</dubbo.version>
<spring-boot.version>2.7.8</spring-boot.version>
<dubbo.version>3.3.0-beta.1</dubbo.version>
<spring-boot.version>3.2.0</spring-boot.version>
Copy link
Copy Markdown
Member

@AlbumenJ AlbumenJ Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<spring-boot.version>3.2.0</spring-boot.version>
<spring-boot.version>3.2.3</spring-boot.version>

Copy link
Copy Markdown
Contributor Author

@3424672656 3424672656 Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change completed

@3424672656 3424672656 requested a review from AlbumenJ March 13, 2024 11:45
@chickenlj
Copy link
Copy Markdown
Contributor

chickenlj commented Mar 14, 2024 •
edited
Loading

Please replace this dependency with dubbo-zookeeper-curator5-spring-boot-starter by referencing the pom.xml file in this sample

@chickenlj
Copy link
Copy Markdown
Contributor

chickenlj commented Mar 14, 2024

And also <dubbo.version>3.3.0-beta.1</dubbo.version> is needed for this starter, so please stick to 3.3.0-beta.1 instead of 3.2.11

@3424672656
Copy link
Copy Markdown
Contributor Author

3424672656 commented Mar 14, 2024

Please review the latest pr

@chickenlj
Copy link
Copy Markdown
Contributor

chickenlj commented Mar 14, 2024

Please review the latest pr

Have you already submitted it? You can cross-reference that pr in the comment here.

@3424672656
Copy link
Copy Markdown
Contributor Author

3424672656 commented Mar 14, 2024

Sorry for my expression error, please review the latest submission

@chickenlj
Copy link
Copy Markdown
Contributor

chickenlj commented Mar 14, 2024

Sorry for my expression error, please review the latest submission

not necessary to reopen a new pr, just submitting to this PR would be fine.

@chickenlj chickenlj mentioned this pull request Mar 14, 2024
Merged
@3424672656
Copy link
Copy Markdown
Contributor Author

3424672656 commented Mar 14, 2024

Is there anything that needs to be revised now?

chickenlj
chickenlj approved these changes Mar 14, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlbumenJ AlbumenJ merged commit 21cb3d7 into apache:master Mar 14, 2024
@3424672656 3424672656 deleted the update_cache_version branch March 14, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chickenlj chickenlj chickenlj approved these changes

@AlbumenJ AlbumenJ Awaiting requested review from AlbumenJ

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@3424672656 @chickenlj @AlbumenJ