Skip to content

[Compatibility Test] Prevent dubbo-samples-migration-case-default being ignored#369

Merged
guohao merged 1 commit intoapache:masterfrom
guohao:specify-migration-consuemr-verison
Sep 17, 2021
Merged

[Compatibility Test] Prevent dubbo-samples-migration-case-default being ignored#369
guohao merged 1 commit intoapache:masterfrom
guohao:specify-migration-consuemr-verison

Conversation

@plusmancn
Copy link
Contributor

If we have the env of DUBBO_VERSION=3.0.3-SNAPSHOT,2.7.13, when the Integration Tests trigger, these properties will be overwritten by maven, for example:

mvn -Ddubbo.provider.version=3.0.3-SNAPSHOT -Ddubbo.consumer.version=2.7.13 -Dspring.version=4.3.16.RELEASE

But in the dubbo-samples's Dubbo 3 CI env, there only has DUBBO_VERSION=3.0.3-SNAPSHOT, we have to specify one side's version to prevent the test being ignored, for example:

dubbo.provider.version=3.*
dubbo.consumer.version=2.7.13 # <= specific version

@guohao guohao merged commit ec3077e into apache:master Sep 17, 2021
@plusmancn plusmancn deleted the specify-migration-consuemr-verison branch September 17, 2021 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants