Skip to content

[3.0-Triple] fix tri TheadPool is default#10019

Merged
chickenlj merged 6 commits intoapache:3.0from
EarthChen:fix-tri-thead-pool
May 10, 2022
Merged

[3.0-Triple] fix tri TheadPool is default#10019
chickenlj merged 6 commits intoapache:3.0from
EarthChen:fix-tri-thead-pool

Conversation

@EarthChen
Copy link
Member

@EarthChen EarthChen commented May 9, 2022

What is the purpose of the change

#10018

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@EarthChen
Copy link
Member Author

org.apache.dubbo.rpc.protocol.tri.TripleHttp2Protocol#lookupExecutor

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2022

Codecov Report

Merging #10019 (f32d11f) into 3.0 (7c72487) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                3.0   #10019      +/-   ##
============================================
- Coverage     65.70%   65.70%   -0.01%     
+ Complexity      319      295      -24     
============================================
  Files          1213     1218       +5     
  Lines         52949    53051     +102     
  Branches       8021     8035      +14     
============================================
+ Hits          34792    34859      +67     
- Misses        14367    14385      +18     
- Partials       3790     3807      +17     
Impacted Files Coverage Δ
...he/dubbo/rpc/protocol/tri/TripleHttp2Protocol.java 90.38% <100.00%> (+2.88%) ⬆️
.../apache/dubbo/rpc/protocol/tri/TripleProtocol.java 85.00% <100.00%> (+0.58%) ⬆️
...nt/metadata/ServiceInstanceHostPortCustomizer.java 65.78% <0.00%> (-21.06%) ⬇️
...he/dubbo/rpc/listener/ListenerExporterWrapper.java 58.82% <0.00%> (-14.71%) ⬇️
...g/apache/dubbo/remoting/api/ConnectionHandler.java 45.45% <0.00%> (-9.10%) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 52.27% <0.00%> (-7.96%) ⬇️
...o/registry/nacos/util/NacosNamingServiceUtils.java 80.35% <0.00%> (-6.19%) ⬇️
...o/rpc/protocol/tri/transport/GracefulShutdown.java 81.48% <0.00%> (-4.24%) ⬇️
.../dubbo/common/threadlocal/InternalThreadLocal.java 75.34% <0.00%> (-4.07%) ⬇️
.../main/java/org/apache/dubbo/rpc/RpcInvocation.java 66.34% <0.00%> (-3.42%) ⬇️
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c72487...f32d11f. Read the comment docs.

Copy link
Member

@wangchengming666 wangchengming666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use THREAD_POOL_URL here

Copy link
Member

@wangchengming666 wangchengming666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit b4bc7aa into apache:3.0 May 10, 2022
@AlbumenJ AlbumenJ added this to the 3.0.9 milestone Jun 20, 2022
guohao pushed a commit to guohao/dubbo that referenced this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants