Skip to content

[3.0] Add some logger related command#10132

Merged
AlbumenJ merged 1 commit intoapache:3.0from
AlbumenJ:0609_log
Jun 9, 2022
Merged

[3.0] Add some logger related command#10132
AlbumenJ merged 1 commit intoapache:3.0from
AlbumenJ:0609_log

Conversation

@AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Jun 9, 2022

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@AlbumenJ AlbumenJ requested a review from chickenlj June 9, 2022 08:37
@chickenlj chickenlj added this to the 3.0.9 milestone Jun 9, 2022
Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2022

Codecov Report

Merging #10132 (639d5be) into 3.0 (0d98caa) will decrease coverage by 0.06%.
The diff coverage is 10.16%.

@@             Coverage Diff              @@
##                3.0   #10132      +/-   ##
============================================
- Coverage     65.71%   65.65%   -0.07%     
+ Complexity      320      319       -1     
============================================
  Files          1220     1223       +3     
  Lines         53147    53205      +58     
  Branches       8057     8060       +3     
============================================
+ Hits          34926    34932       +6     
- Misses        14408    14456      +48     
- Partials       3813     3817       +4     
Impacted Files Coverage Δ
.../apache/dubbo/qos/command/impl/SwitchLogLevel.java 4.76% <4.76%> (ø)
.../org/apache/dubbo/common/logger/LoggerFactory.java 36.92% <10.71%> (-20.98%) ⬇️
.../org/apache/dubbo/qos/command/impl/LoggerInfo.java 20.00% <20.00%> (ø)
...rg/apache/dubbo/qos/command/impl/SwitchLogger.java 20.00% <20.00%> (ø)
.../dubbo/rpc/protocol/tri/command/QueuedCommand.java 64.28% <0.00%> (-14.29%) ⬇️
...e/dubbo/rpc/protocol/tri/transport/WriteQueue.java 73.80% <0.00%> (-4.77%) ⬇️
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) ⬇️
...ting/zookeeper/curator/CuratorZookeeperClient.java 68.26% <0.00%> (-1.93%) ⬇️
...etadata/report/support/AbstractMetadataReport.java 67.71% <0.00%> (-1.80%) ⬇️
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 59.36% <0.00%> (-0.64%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d98caa...639d5be. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 372f6a6 into apache:3.0 Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants