fix validate violations is swallowed by ValidationException for issue#10415#10434
Closed
zhouxinlei828 wants to merge 2 commits intoapache:3.0from
Closed
fix validate violations is swallowed by ValidationException for issue#10415#10434zhouxinlei828 wants to merge 2 commits intoapache:3.0from
zhouxinlei828 wants to merge 2 commits intoapache:3.0from
Conversation
Author
|
fix issue#10415 |
Codecov Report
@@ Coverage Diff @@
## 3.0 #10434 +/- ##
============================================
- Coverage 65.68% 65.65% -0.04%
- Complexity 296 318 +22
============================================
Files 1234 1234
Lines 53913 53913
Branches 8155 8156 +1
============================================
- Hits 35415 35395 -20
- Misses 14645 14670 +25
+ Partials 3853 3848 -5
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
AlbumenJ
requested changes
Aug 10, 2022
| } | ||
| } catch (ValidationException e) { | ||
| // only use exception's message to avoid potential serialization issue | ||
| throw new ValidationException(e.getMessage()); |
Member
There was a problem hiding this comment.
javax.validation.ConstraintViolationException might have potential serialization issue. Should be converted.
Contributor
|
|
Contributor
|
Check conclustion in #10415 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
fix validate violations is swallowed by ValidationException
Brief changelog
Verifying this change
Checklist