Skip to content

Avoid getting the whitelist every time and causing performance degradation#10775

Merged
AlbumenJ merged 2 commits intoapache:3.1from
CrazyHZM:optimization/performance
Oct 22, 2022
Merged

Avoid getting the whitelist every time and causing performance degradation#10775
AlbumenJ merged 2 commits intoapache:3.1from
CrazyHZM:optimization/performance

Conversation

@CrazyHZM
Copy link
Member

Signed-off-by: crazyhzm crazyhzm@gmail.com

What is the purpose of the change

System.getProperty is executed for each execution, causing the thread to be blocked.

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

…ation

Signed-off-by: crazyhzm <crazyhzm@gmail.com>
…ation

Signed-off-by: crazyhzm <crazyhzm@gmail.com>
@CrazyHZM CrazyHZM added this to the 3.1.2 milestone Oct 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2022

Codecov Report

Merging #10775 (fd7531b) into 3.1 (a66f512) will decrease coverage by 0.37%.
The diff coverage is 36.36%.

@@             Coverage Diff              @@
##                3.1   #10775      +/-   ##
============================================
- Coverage     65.25%   64.88%   -0.38%     
+ Complexity      494      491       -3     
============================================
  Files          1336     1336              
  Lines         56930    56929       -1     
  Branches       8421     8421              
============================================
- Hits          37151    36939     -212     
- Misses        15831    16034     +203     
- Partials       3948     3956       +8     
Impacted Files Coverage Δ
...an2/dubbo/WhitelistHessian2FactoryInitializer.java 0.00% <0.00%> (ø)
...ize/hessian2/dubbo/Hessian2FactoryInitializer.java 75.00% <80.00%> (+15.00%) ⬆️
...mmon/serialize/fastjson2/FastJson2ObjectInput.java 0.00% <0.00%> (-62.50%) ⬇️
...mon/serialize/fastjson2/FastJson2ObjectOutput.java 0.00% <0.00%> (-56.25%) ⬇️
...dubbo/remoting/zookeeper/ZookeeperTransporter.java 50.00% <0.00%> (-33.34%) ⬇️
...on/serialize/fastjson2/FastJson2Serialization.java 57.14% <0.00%> (-28.58%) ⬇️
...ng/zookeeper/curator5/Curator5ZookeeperClient.java 43.86% <0.00%> (-27.36%) ⬇️
...dubbo/common/status/support/LoadStatusChecker.java 41.66% <0.00%> (-25.00%) ⬇️
...nt/metadata/ServiceInstanceHostPortCustomizer.java 65.78% <0.00%> (-21.06%) ⬇️
...n/serialize/fastjson2/Fastjson2CreatorManager.java 46.66% <0.00%> (-20.00%) ⬇️
... and 37 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlbumenJ AlbumenJ merged commit 400f756 into apache:3.1 Oct 22, 2022
@CrazyHZM CrazyHZM deleted the optimization/performance branch October 23, 2022 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants