Skip to content

Fix ssl npe#11092

Closed
CrazyHZM wants to merge 1 commit into
apache:3.0from
CrazyHZM:fix/ssl_npe
Closed

Fix ssl npe#11092
CrazyHZM wants to merge 1 commit into
apache:3.0from
CrazyHZM:fix/ssl_npe

Conversation

@CrazyHZM
Copy link
Copy Markdown
Member

@CrazyHZM CrazyHZM commented Dec 8, 2022

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@CrazyHZM CrazyHZM added this to the 3.0.13 milestone Dec 8, 2022
@CrazyHZM CrazyHZM closed this Dec 8, 2022
@CrazyHZM CrazyHZM removed this from the 3.0.13 milestone Dec 8, 2022
@CrazyHZM CrazyHZM deleted the fix/ssl_npe branch December 8, 2022 04:33
@CrazyHZM CrazyHZM restored the fix/ssl_npe branch December 8, 2022 04:47
@CrazyHZM CrazyHZM reopened this Dec 8, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 8, 2022

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.04%. Comparing base (d192c7b) to head (4aa7c45).
⚠️ Report is 10 commits behind head on 3.0.

Files with missing lines Patch % Lines
...bbo/remoting/api/PortUnificationServerHandler.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.0   #11092      +/-   ##
============================================
+ Coverage     66.01%   66.04%   +0.03%     
- Complexity      317      319       +2     
============================================
  Files          1240     1240              
  Lines         54041    54042       +1     
  Branches       8179     8180       +1     
============================================
+ Hits          35673    35691      +18     
+ Misses        14508    14494      -14     
+ Partials       3860     3857       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CrazyHZM CrazyHZM closed this Dec 8, 2022
@CrazyHZM CrazyHZM deleted the fix/ssl_npe branch January 6, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants