Improve type safety of CollectionUtils.toTreeSet#16306
Open
skt-shinyruo wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.3 #16306 +/- ##
============================================
- Coverage 60.80% 60.78% -0.03%
+ Complexity 11766 11764 -2
============================================
Files 1953 1953
Lines 89188 89201 +13
Branches 13454 13457 +3
============================================
- Hits 54235 54218 -17
- Misses 29391 29413 +22
- Partials 5562 5570 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RainYuY
requested changes
Jun 3, 2026
RainYuY
approved these changes
Jun 4, 2026
Contributor
Author
|
Hi @zrlw, RainYuY has approved the latest commit and all checks are passing. Could you please take another look when available? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change?
GitHub_issue: Fixes #16297
This pull request improves the type safety of
CollectionUtils.toTreeSet.The existing single-argument overload accepted any
Set<T>, but its implementation delegates toTreeSet, which requires naturally comparable elements unless a comparator is provided. The updated signature makes that requirement explicit at compile time:This pull request also adds a comparator-based overload for custom ordering and non-
Comparableelement types:For non-null empty inputs, the comparator overload returns an empty
TreeSetthat preserves the provided comparator.Verification:
mvn -pl dubbo-common -Dtest=CollectionUtilsTest testgit diff --checkChecklist