Fix IPv4 address port parsing in NetUtils#16309
Open
yin-bo-Final wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3.3 #16309 +/- ##
============================================
+ Coverage 60.77% 60.79% +0.01%
+ Complexity 11768 15 -11753
============================================
Files 1953 1953
Lines 89196 89196
Branches 13457 13458 +1
============================================
+ Hits 54212 54223 +11
+ Misses 29418 29405 -13
- Partials 5566 5568 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
13b5b3e to
71a360b
Compare
71a360b to
b63b256
Compare
Author
|
The failed Samples Test seems caused by Docker Hub timeout while pulling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16308
What is the purpose of the change?
This PR fixes
NetUtils.matchIpExpression(String, String)so it can correctly parse normal IPv4host:portaddresses, such as192.168.1.63:90.Previously, the method only split the address when it ended with
:, so a normal IPv4 address with port was treated as the full host string and could fail withUnknownHostException.The fix parses the address only when it contains exactly one colon, avoiding impact on IPv6 addresses.
Checklist