Skip to content

optimize : use constants as callers to the equals() method#5352

Merged
chickenlj merged 2 commits intoapache:masterfrom
ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz:optimize_1
Dec 18, 2019
Merged

optimize : use constants as callers to the equals() method#5352
chickenlj merged 2 commits intoapache:masterfrom
ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz:optimize_1

Conversation

@ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz
Copy link

@ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz ggezzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzzz commented Nov 19, 2019

What is the purpose of the change

optimize : use constants as callers to the equals() method

Brief changelog

1.dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/loadbalance/AbstractLoadBalance.java
2.dubbo-common/src/main/java/org/apache/dubbo/common/constants/RegistryConstants.java

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

codecov-io commented Nov 28, 2019

Codecov Report

Merging #5352 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5352      +/-   ##
============================================
+ Coverage     61.17%   61.19%   +0.02%     
  Complexity      424      424              
============================================
  Files           919      919              
  Lines         37487    37486       -1     
  Branches       5461     5461              
============================================
+ Hits          22933    22940       +7     
+ Misses        12049    12041       -8     
  Partials       2505     2505
Impacted Files Coverage Δ Complexity Δ
...o/rpc/cluster/loadbalance/AbstractLoadBalance.java 68.18% <100%> (-1.39%) 0 <0> (ø)
...pache/dubbo/remoting/transport/AbstractServer.java 53.75% <0%> (-3.75%) 0% <0%> (ø)
...g/apache/dubbo/rpc/protocol/rest/RestProtocol.java 68.21% <0%> (-3.11%) 0% <0%> (ø)
...he/dubbo/registry/multicast/MulticastRegistry.java 67.87% <0%> (-1.81%) 0% <0%> (ø)
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 89.71% <0%> (-0.94%) 16% <0%> (-1%)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 62.5% <0%> (+0.62%) 29% <0%> (ø) ⬇️
.../exchange/support/header/HeaderExchangeServer.java 67.92% <0%> (+0.94%) 0% <0%> (ø) ⬇️
...exchange/support/header/HeaderExchangeHandler.java 64.6% <0%> (+2.65%) 0% <0%> (ø) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 55.68% <0%> (+3.4%) 20% <0%> (+1%) ⬆️
.../org/apache/dubbo/remoting/ExecutionException.java 21.05% <0%> (+5.26%) 0% <0%> (ø) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9746a0...6024085. Read the comment docs.

Copy link
Contributor

@maoyiz maoyiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM>

@chickenlj chickenlj merged commit d4d016b into apache:master Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants