Skip to content

Enhance StringUtils#parseParameters#5448

Merged
chickenlj merged 1 commit intoapache:masterfrom
GungnirLaevatain:polish
Dec 10, 2019
Merged

Enhance StringUtils#parseParameters#5448
chickenlj merged 1 commit intoapache:masterfrom
GungnirLaevatain:polish

Conversation

@GungnirLaevatain
Copy link
Contributor

What is the purpose of the change

precompile regex pattern to avoid compile multiple times

Verifying this change

Pass the org.apache.dubbo.common.utils.StringUtilsTest#testParseParameters

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

Codecov Report

Merging #5448 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5448      +/-   ##
============================================
- Coverage     61.23%   61.18%   -0.06%     
  Complexity      424      424              
============================================
  Files           919      919              
  Lines         37520    37520              
  Branches       5462     5462              
============================================
- Hits          22975    22956      -19     
- Misses        12036    12053      +17     
- Partials       2509     2511       +2
Impacted Files Coverage Δ Complexity Δ
...ava/org/apache/dubbo/common/utils/StringUtils.java 74.92% <100%> (ø) 0 <0> (ø) ⬇️
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 46.15% <0%> (-23.08%) 0% <0%> (ø)
...ache/dubbo/remoting/transport/AbstractChannel.java 75% <0%> (-12.5%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyClientHandler.java 57.62% <0%> (-8.48%) 0% <0%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0%> (-6.9%) 0% <0%> (ø)
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0%> (-5.27%) 0% <0%> (ø)
...pache/dubbo/remoting/transport/AbstractServer.java 53.75% <0%> (-3.75%) 0% <0%> (ø)
...c/main/java/org/apache/dubbo/rpc/RpcException.java 80% <0%> (-3.34%) 0% <0%> (ø)
...exchange/support/header/HeaderExchangeHandler.java 61.94% <0%> (-2.66%) 0% <0%> (ø)
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 63.1% <0%> (-0.35%) 0% <0%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8eae301...cc05bad. Read the comment docs.

@chickenlj chickenlj added this to the 2.7.5 milestone Dec 10, 2019
@chickenlj chickenlj merged commit 0ebbeab into apache:master Dec 10, 2019
@GungnirLaevatain GungnirLaevatain deleted the polish branch December 10, 2019 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants