Skip to content

code optimization: fix some typos and remove Deprecated method #5546

Closed
LiosWong wants to merge 20 commits intoapache:masterfrom
LiosWong:master
Closed

code optimization: fix some typos and remove Deprecated method #5546
LiosWong wants to merge 20 commits intoapache:masterfrom
LiosWong:master

Conversation

@LiosWong
Copy link
Contributor

@LiosWong LiosWong commented Dec 27, 2019

What is the purpose of the change

1. fix typo execugtelimit_filter_start_time:

private static final String EXECUTELIMIT_FILTER_START_TIME = "execugtelimit_filter_start_time";

2. fix typo Licycle:

* Consider implementing {@code Licycle} to enable executors shutdown when the process stops.

3. fix typo:SEPERATOR

4. remove Deprecated method getDispatcher()、setDispather() in org.apache.dubbo.config.ProtocolConfig

5. remove unused code in DefaultExecutorRepository

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-io
Copy link

codecov-io commented Dec 27, 2019

Codecov Report

Merging #5546 into master will increase coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5546      +/-   ##
============================================
+ Coverage     61.17%   61.19%   +0.01%     
  Complexity      423      423              
============================================
  Files           922      922              
  Lines         37512    37500      -12     
  Branches       5433     5432       -1     
============================================
- Hits          22949    22948       -1     
+ Misses        12074    12062      -12     
- Partials       2489     2490       +1
Impacted Files Coverage Δ Complexity Δ
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 63.77% <ø> (-0.04%) 0 <0> (ø)
.../threadpool/manager/DefaultExecutorRepository.java 61.81% <ø> (ø) 0 <0> (ø) ⬇️
...n/java/org/apache/dubbo/config/ProtocolConfig.java 94.16% <ø> (+1.48%) 0 <0> (ø) ⬇️
...ache/dubbo/registry/etcd/EtcdServiceDiscovery.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...che/dubbo/common/compiler/support/JdkCompiler.java 63.2% <ø> (-1.34%) 0 <0> (ø)
...rg/apache/dubbo/rpc/filter/ExecuteLimitFilter.java 65.21% <ø> (ø) 0 <0> (ø) ⬇️
...he/dubbo/common/threadpool/ThreadlessExecutor.java 55% <ø> (-5%) 0 <0> (ø)
...ache/dubbo/config/utils/ConfigValidationUtils.java 75.84% <ø> (-0.1%) 0 <0> (ø)
...apache/dubbo/common/constants/CommonConstants.java 100% <ø> (ø) 0 <0> (ø) ⬇️
...a/org/apache/dubbo/common/BaseServiceMetadata.java 41.17% <0%> (ø) 0 <0> (ø) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e4e6b7...39bd0c2. Read the comment docs.

@chickenlj chickenlj added this to the 2.7.6 milestone Dec 30, 2019
@LiosWong LiosWong closed this Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments