Add test cases for NacosMetadataReport#5776
Merged
mercyblitz merged 5 commits intoapache:masterfrom Mar 6, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5776 +/- ##
===========================================
+ Coverage 61.17% 61.38% +0.2%
- Complexity 471 496 +25
===========================================
Files 926 979 +53
Lines 37843 38871 +1028
Branches 5461 5602 +141
===========================================
+ Hits 23152 23862 +710
- Misses 12179 12383 +204
- Partials 2512 2626 +114
Continue to review full report at Codecov.
|
chickenlj
pushed a commit
that referenced
this pull request
Mar 10, 2020
* Add more test case for NacosMetadataReport * Modify codes * Modify comments * Add more test case and modify codes * Modify codes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Add test case for NacosMetadataReport
Brief changelog
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false&mvn clean test-compile failsafe:integration-testto make sure unit-test and integration-test pass.