Skip to content

service discovery registry protocol unit test#8635

Closed
shanuo0312 wants to merge 28 commits intoapache:3.0from
shanuo0312:3.0
Closed

service discovery registry protocol unit test#8635
shanuo0312 wants to merge 28 commits intoapache:3.0from
shanuo0312:3.0

Conversation

@shanuo0312
Copy link
Contributor

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Aug 29, 2021

Codecov Report

Merging #8635 (b5a17e8) into 3.0 (a50810b) will decrease coverage by 0.04%.
The diff coverage is 58.95%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8635      +/-   ##
============================================
- Coverage     62.96%   62.91%   -0.05%     
  Complexity      313      313              
============================================
  Files          1113     1117       +4     
  Lines         46693    46811     +118     
  Branches       7027     7046      +19     
============================================
+ Hits          29400    29451      +51     
- Misses        14046    14075      +29     
- Partials       3247     3285      +38     
Impacted Files Coverage Δ
.../rpc/cluster/router/condition/ConditionRouter.java 70.30% <ø> (-0.36%) ⬇️
...rpc/cluster/router/mesh/route/MeshEnvListener.java 0.00% <ø> (ø)
...apache/dubbo/common/constants/CommonConstants.java 100.00% <ø> (ø)
...apache/dubbo/common/extension/ExtensionLoader.java 79.41% <ø> (ø)
...n/java/org/apache/dubbo/config/AbstractConfig.java 81.03% <ø> (ø)
...ain/java/org/apache/dubbo/config/ModuleConfig.java 86.66% <ø> (ø)
...in/java/org/apache/dubbo/config/ServiceConfig.java 70.68% <ø> (-0.36%) ⬇️
...notation/ReferenceAnnotationBeanPostProcessor.java 87.80% <ø> (ø)
...dubbo/config/spring/util/DubboAnnotationUtils.java 48.27% <ø> (ø)
.../client/metadata/ServiceInstanceMetadataUtils.java 81.91% <0.00%> (-3.04%) ⬇️
... and 108 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a50810b...b5a17e8. Read the comment docs.

@AlbumenJ
Copy link
Member

AlbumenJ commented Sep 8, 2021

Please resolve confilct

@chickenlj
Copy link
Contributor

Reopen when conflicts resolved

@chickenlj chickenlj closed this Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants