Skip to content

Comments

Remove CustomizedLoaderClassPath.java#9105

Merged
chickenlj merged 1 commit intoapache:3.0from
AlbumenJ:1023_fix_classpath
Oct 27, 2021
Merged

Remove CustomizedLoaderClassPath.java#9105
chickenlj merged 1 commit intoapache:3.0from
AlbumenJ:1023_fix_classpath

Conversation

@AlbumenJ
Copy link
Member

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@CrazyHZM CrazyHZM added this to the 3.0.5 milestone Oct 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2021

Codecov Report

Merging #9105 (e5167ca) into 3.0 (81f240e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##                3.0    #9105   +/-   ##
=========================================
  Coverage     64.75%   64.76%           
- Complexity      325      326    +1     
=========================================
  Files          1177     1176    -1     
  Lines         50723    50690   -33     
  Branches       7550     7540   -10     
=========================================
- Hits          32848    32829   -19     
+ Misses        14314    14307    -7     
+ Partials       3561     3554    -7     
Impacted Files Coverage Δ
...g/apache/dubbo/common/bytecode/ClassGenerator.java 62.63% <100.00%> (+0.20%) ⬆️
...java/org/apache/dubbo/common/bytecode/Wrapper.java 82.67% <100.00%> (+0.08%) ⬆️
...dubbo/remoting/exchange/support/DefaultFuture.java 88.03% <0.00%> (-5.13%) ⬇️
...bbo/common/resource/GlobalResourcesRepository.java 77.08% <0.00%> (-2.09%) ⬇️
...etadata/report/support/AbstractMetadataReport.java 65.56% <0.00%> (-1.89%) ⬇️
...ting/zookeeper/curator/CuratorZookeeperClient.java 70.67% <0.00%> (-0.97%) ⬇️
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 85.22% <0.00%> (-0.69%) ⬇️
...ubbo/config/deploy/DefaultApplicationDeployer.java 75.67% <0.00%> (-0.20%) ⬇️
...he/dubbo/remoting/transport/netty/NettyServer.java 73.68% <0.00%> (+3.50%) ⬆️
...ubbo/rpc/protocol/tri/ServerTransportObserver.java 70.21% <0.00%> (+4.25%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81f240e...e5167ca. Read the comment docs.

Copy link
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chickenlj chickenlj merged commit deb6b57 into apache:3.0 Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants