Fix not find server provider startup time#9712
Fix not find server provider startup time#9712xiaochangbai wants to merge 2 commits intoapache:3.0from
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.0 #9712 +/- ##
============================================
+ Coverage 65.67% 65.69% +0.02%
Complexity 296 296
============================================
Files 1193 1193
Lines 52384 52388 +4
Branches 7956 7956
============================================
+ Hits 34404 34418 +14
+ Misses 14260 14254 -6
+ Partials 3720 3716 -4
Continue to review full report at Codecov.
|
BurningCN
left a comment
There was a problem hiding this comment.
In fact, there is no need to do this. The provider has a timestamp parameter when registering, but when the registration goes to the MetadataInfo#addService method, the internal logic causes the parameter to be removed due to KEYS_TO_REMOVE. So the solution is to remove timestamp from KEYS_TO_REMOVE.
In addition, this modification is only for the application level, and the interface level also needs to be adjusted (CacheableFailbackRegistry#toUrlsWithoutEmpty also removes the timestamp of the provider url).
|
I see. I didn't notice these two removal operations at that time |
|
TIMESTAMP key should not pass in metainfo, which is a cache for services' info for static information. BTW, it would be more proper to pass TIMESTAMP in instance info. |
What is the purpose of the change
Fix the problem that the server provider startup time cannot be found on the consumer side
close #9675
Brief changelog
Verifying this change
Checklist