Skip to content

[issue-9812] upgrade libthrift due to security issue#9813

Merged
CrazyHZM merged 1 commit intoapache:3.0from
pjfanning:upgrade-thrift
Mar 21, 2022
Merged

[issue-9812] upgrade libthrift due to security issue#9813
CrazyHZM merged 1 commit intoapache:3.0from
pjfanning:upgrade-thrift

Conversation

@pjfanning
Copy link
Member

What is the purpose of the change

#9812

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2022

Codecov Report

Merging #9813 (12b3867) into 3.0 (6eaf095) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                3.0    #9813   +/-   ##
=========================================
  Coverage     65.61%   65.61%           
+ Complexity      320      319    -1     
=========================================
  Files          1208     1208           
  Lines         52545    52545           
  Branches       7972     7972           
=========================================
+ Hits          34476    34478    +2     
+ Misses        14323    14320    -3     
- Partials       3746     3747    +1     
Impacted Files Coverage Δ
...che/dubbo/registry/client/NopServiceDiscovery.java 44.44% <0.00%> (-11.12%) ⬇️
...ian2/dubbo/AbstractHessian2FactoryInitializer.java 50.00% <0.00%> (-11.12%) ⬇️
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) ⬇️
...bbo/common/resource/GlobalResourcesRepository.java 70.90% <0.00%> (-1.82%) ⬇️
...exchange/support/header/HeaderExchangeHandler.java 61.06% <0.00%> (-1.77%) ⬇️
...ubbo/registry/client/AbstractServiceDiscovery.java 83.05% <0.00%> (-1.70%) ⬇️
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 85.56% <0.00%> (+0.34%) ⬆️
...java/org/apache/dubbo/remoting/api/Connection.java 69.49% <0.00%> (+0.84%) ⬆️
...ting/zookeeper/curator/CuratorZookeeperClient.java 70.19% <0.00%> (+0.96%) ⬆️
...pache/dubbo/registry/support/AbstractRegistry.java 76.79% <0.00%> (+1.70%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eaf095...12b3867. Read the comment docs.

Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CrazyHZM CrazyHZM linked an issue Mar 21, 2022 that may be closed by this pull request
1 task
@CrazyHZM CrazyHZM merged commit 7c3f796 into apache:3.0 Mar 21, 2022
@CrazyHZM CrazyHZM added this to the 3.0.7 milestone Mar 21, 2022
@pjfanning pjfanning deleted the upgrade-thrift branch March 21, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

upgrade libthrift due to security issue

4 participants