Skip to content
This repository was archived by the owner on May 12, 2021. It is now read-only.

[MINOR] Migrate 0.5.0-incubating-SNAPSHOT to 0.5.0-SNAPSHOT#757

Closed
haoch wants to merge 13 commits intoapache:masterfrom
haoch:UpdateVersion
Closed

[MINOR] Migrate 0.5.0-incubating-SNAPSHOT to 0.5.0-SNAPSHOT#757
haoch wants to merge 13 commits intoapache:masterfrom
haoch:UpdateVersion

Conversation

@haoch
Copy link
Member

@haoch haoch commented Dec 23, 2016

Migrate 0.5.0-incubating-SNAPSHOT to 0.5.0-SNAPSHOT as Eagle graduated from incubator and becomes TLP

@anyway1021
Copy link
Contributor

LGTM

@jhsenjaliya
Copy link
Contributor

jhsenjaliya commented Dec 27, 2016

Hi Hao,
Search for "incubating" in entire project gave me 100+ files ( 98 xml files with some 5 test files and other readme's ),
wondering if this PR covers all of them.
after fetching this PR, i find more 32 files still have "incubating", Please take a look.

@anyway1021
Copy link
Contributor

@haoch Hao, what's the plan of migration? Step by step, or complete it with 1 shot?

@haoch
Copy link
Member Author

haoch commented Dec 28, 2016

@jhsenjaliya good catch, will fix it accordingly.
@anyway1021, this PR will only fix the version-related things in source code, please feel free to clean other steps if any missing in separated PR.

-->
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we doing 120 char line limit ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the 120 limitation to 200 in checkstyle.xml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it, Thanks

@haoch
Copy link
Member Author

haoch commented Dec 29, 2016

@jhsenjaliya I think i have resolved all "incubating" things, please help review again.

@jhsenjaliya
Copy link
Contributor

@haoch, found 1 last reference in LICENSE file having text like "Apache Eagle (incubating) Subcomponents:" , otherwise looks good.

@haoch
Copy link
Member Author

haoch commented Dec 30, 2016

@jhsenjaliya fixed as well. If no more problem, I will merge the PR.

@asfgit asfgit closed this in 8b3729f Dec 30, 2016
@haoch
Copy link
Member Author

haoch commented Dec 30, 2016

Thanks @anyway1021 and @jhsenjaliya for reviewing. The pr has been merged now.

jhsenjaliya pushed a commit to jhsenjaliya/eagle that referenced this pull request Jul 12, 2017
Migrate `0.5.0-incubating-SNAPSHOT` to `0.5.0-SNAPSHOT` as Eagle graduated from incubator and becomes TLP

Author: Hao Chen <hao@apache.org>

Closes apache#757 from haoch/UpdateVersion.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants