This repository was archived by the owner on May 12, 2021. It is now read-only.
[MINOR] Change default-rack to /default-rack#787
Closed
r7raul1984 wants to merge 2 commits intoapache:masterfrom
Closed
[MINOR] Change default-rack to /default-rack#787r7raul1984 wants to merge 2 commits intoapache:masterfrom
r7raul1984 wants to merge 2 commits intoapache:masterfrom
Conversation
r7raul1984
commented
Jan 20, 2017
r7raul1984
commented
- Change default-rack to /default-rack
Contributor
|
Why do you need this change? |
Contributor
|
At the initial design, we prefer to extract the 'exact rack info', for example, '/rack-45' -> 'rack-45', '/' will be removed. |
Author
|
@qingwen220 Because ClusterNodeAPITopologyRackResolver use "/default-rack" .I think it will issue some problem when you complete EAGLE-876. |
Contributor
|
It does not matter. The node with a new rack info will replace the old one |
r7raul1984
changed the title
r7raul1984
changed the title
jhsenjaliya
pushed a commit
to jhsenjaliya/eagle
that referenced
this pull request
Jul 12, 2017
- Change default-rack to /default-rack Author: r7raul1984 <tangjijun@yhd.com> Closes apache#787 from r7raul1984/DEFAULT-RACK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.