This repository was archived by the owner on May 12, 2021. It is now read-only.
[EAGLE-866] Refactor HBase JMX Metric with appropriate navigation path#797
Closed
koone wants to merge 8 commits intoapache:masterfrom
Closed
[EAGLE-866] Refactor HBase JMX Metric with appropriate navigation path#797koone wants to merge 8 commits intoapache:masterfrom
koone wants to merge 8 commits intoapache:masterfrom
Conversation
koone
changed the title
r7raul1984
reviewed
Feb 9, 2017
|
|
||
| hadoopMetricApp.route("HadoopMetric", { | ||
| url: "/hadoopMetric?startTime&endTime", | ||
| url: "/Service/HBase/overview?startTime&endTime", |
There was a problem hiding this comment.
I think "/Service/HBase/overview" should be "/Services/HBase/overview"
zombieJ
suggested changes
Feb 13, 2017
|
|
||
| hadoopMetricApp.route("HadoopMetric", { | ||
| url: "/hadoopMetric?startTime&endTime", | ||
| url: "/Services/HBase/overview?startTime&endTime", |
Contributor
There was a problem hiding this comment.
first letter use lower case.
Member
|
@zombieJ how about the review progress? |
zombieJ
approved these changes
Feb 17, 2017
jhsenjaliya
pushed a commit
to jhsenjaliya/eagle
that referenced
this pull request
Jul 12, 2017
<!--
{% comment %}
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to you under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
{% endcomment %}
-->
Refactor HBase JMX Metric with appropriate navigation path
https://issues.apache.org/jira/browse/EAGLE-866
Author: koone <luokun1028@126.com>
Closes apache#797 from koone/EAGLE-866.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor HBase JMX Metric with appropriate navigation path
https://issues.apache.org/jira/browse/EAGLE-866