This repository was archived by the owner on May 12, 2021. It is now read-only.
[EAGLE-924]urls to healthy and unhealthy region-servers in hbase dashboard is not accurate enough#840
Closed
denglingang wants to merge 3 commits intoapache:masterfrom
Closed
[EAGLE-924]urls to healthy and unhealthy region-servers in hbase dashboard is not accurate enough#840denglingang wants to merge 3 commits intoapache:masterfrom
denglingang wants to merge 3 commits intoapache:masterfrom
Conversation
…hboard is not accurate enough - Add status filter in web url,append "?status=healthy" or "?status=unhealthy" to the url - Fix exception when we change time interval - Fix dashboard show when no data and exception. https://issues.apache.org/jira/browse/EAGLE-924
Member
|
@zombieJ please help review about it. |
Member
|
@anyway1021 please confirm about the changes and deploy to QA to validate whether https://issues.apache.org/jira/browse/EAGLE-924 is resolved. |
Member
Author
|
@anyway1021 has the problem about EAGLE-924 been solved? Thanks. |
haoch
reviewed
Feb 27, 2017
| $scope.site = $wrapState.param.siteId; | ||
| var result = cache[name] || activeMasterInfo._promise.then(function (res) { | ||
| var hostname = cache[hostname] = cache[hostname] || res[0].tags.hostname; | ||
| if(typeof res[0].tags === 'undefined') { |
Member
There was a problem hiding this comment.
Maybe it possible: res.length == 0?
Member
Author
There was a problem hiding this comment.
Thanks for your review and suggestion, I have fixed it.
- Fix some display problem to make ui more meaningful.
Member
|
LGTM |
jhsenjaliya
pushed a commit
to jhsenjaliya/eagle
that referenced
this pull request
Jul 12, 2017
…hboard is not accurate enough [EAGLE-924]urls to healthy and unhealthy region-servers in hbase dashboard is not accurate enough - Add status filter in web url,append "?status=healthy" or "?status=unhealthy" to the url - Fix exception when we change time interval - Fix dashboard show when no data and exception. https://issues.apache.org/jira/browse/EAGLE-924 Author: chitin <chitin1027@gmail.com> Closes apache#840 from chitin/eagle924.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[EAGLE-924]urls to healthy and unhealthy region-servers in hbase dashboard is not accurate enough
https://issues.apache.org/jira/browse/EAGLE-924