EAGLE-993: add duplicate removal settings in policy definition#926
EAGLE-993: add duplicate removal settings in policy definition#926qingwen220 wants to merge 16 commits intoapache:masterfrom
Conversation
| .name("Email") | ||
| .type(AlertEmailPublisher.class) | ||
| .description("Email alert publisher") | ||
| .field("subject") |
There was a problem hiding this comment.
Yes.
As we already define the email subject in the policy definition. it's a little duplicated. How do you think?
There was a problem hiding this comment.
right, its duplicated, Thanks
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| --> |
There was a problem hiding this comment.
My mistake. I will add it back.
| // remove the column values for publish plugin match | ||
| partition.getColumnValues().clear(); | ||
| if (!publishPluginMapping.containsKey(partition)) { | ||
| if (!publishPluginMapping.containsKey(partition.getPublishId())) { |
There was a problem hiding this comment.
In publisher, we are able to specify the accepted streamId list, here how can we handle dropping the alert which comes from the stream which is NOT defined in accepted streamId list?
There was a problem hiding this comment.
Sorry for the late reply.
For the alert dropping off of unwanted stream is handled in AlertBoltOutputCollectorWrapper, which are kept as it is.
In this class, i just simplify the coding, which should keeps the original logic. How do you think? @garrettlish
There was a problem hiding this comment.
u can keep you simplified code, it looks good
| if (deduplicatorMap != null && deduplicatorMap.containsKey(event.getPolicyId())) { | ||
| List<AlertStreamEvent> eventList = deduplicatorMap.get(event.getPolicyId()).dedup(event); | ||
| if (eventList == null || eventList.isEmpty()) { | ||
| return; |
There was a problem hiding this comment.
You are right. Thanks
|
+1 |
https://issues.apache.org/jira/browse/EAGLE-993 Author: Zhao, Qingwen <qingwzhao@apache.org> Closes apache#926 from qingwen220/EAGLE-993.
4 participants
https://issues.apache.org/jira/browse/EAGLE-993