This repository was archived by the owner on May 12, 2021. It is now read-only.
EAGLE-1038: Support alertDuplication customization for each policy#944
Closed
qingwen220 wants to merge 2 commits intoapache:masterfrom
Closed
EAGLE-1038: Support alertDuplication customization for each policy#944qingwen220 wants to merge 2 commits intoapache:masterfrom
qingwen220 wants to merge 2 commits intoapache:masterfrom
Conversation
asdf2014
reviewed
Jun 7, 2017
| private long createdTime; | ||
| private String category; | ||
| private AlertSeverity severity = AlertSeverity.WARNING; | ||
| private boolean duplicationChecked = false; |
Member
There was a problem hiding this comment.
Just using private boolean duplicationChecked; is fine, because the default value of boolean in jdk is false.
Contributor
Author
There was a problem hiding this comment.
what if the default value changes in different JDK versions?
Member
There was a problem hiding this comment.
I think it is impossible to change it, because there is no other better way to design it and redesignning it will bring too much impact ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/EAGLE-1038