fix bug #11049#11212
Conversation
|
|
||
| if (toolboxOpt && toolboxOpt.feature) { | ||
| var dataZoomOpt = toolboxOpt.feature.dataZoom; | ||
| var dataZoomOpt = toolboxOpt.feature.dataZoom || {}; |
There was a problem hiding this comment.
-
Add a default
{}will make the condition at L281 no longer make sense. So only add a{}is not enough. -
Add a defualt
{}will cause thatdataZoommodels are always added whatevertoolbox.featrue.dataZoomdeclared. I am worried that might bring some other bug or bad cases.
And event we fix this error throw in this way, there are other issue: ifsetOptionchanges the axes, thetoolbox dataZoomwill not follow and will also be buggy.
I think this issue is a little complicated:
Currently, making a hidden dataZoom model is performed in the preprocess stage,
which can not take the existing options into account. But they need that, because
they need the axes info.
If we want to resolve this kind of issue thoroughly, we might need another stage,
perhaps in setOption(the second round of setOption, only triggered inside),
to insert/update this kind of hidden model, where the existing model (like axes)
can be taken into account.
Anyway, before we resolve it totally, we can probably consider the feature toolbox dataZoom
only support being used in the first setOption.
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you wish not to mark it as stale, please leave a comment in this PR. We are sorry for this but 2 years is a long time and the code base has been changed a lot. Thanks for your contribution anyway. |
|
This PR has been automatically closed because it has not had recent activity. Sorry for that and we are looking forward to your next contribution. |
The

toolboxhas been updated when using the dataZoom in dynamic added toolbox, but thedataZoomhasn't been updated.