Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(markLine): fix axis type in markLine data and close #14300 #14314

Merged
merged 1 commit into from Feb 23, 2021

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Feb 22, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

string is a valid type for markLine.data because time axis values can be string. This PR adds string to its type.

Fixed issues

Details

Before: What was the problem?

Only number is supported for MarkLine1DDataItemOption.xAxis.

After: How is it fixed in this PR?

Set the type to be number | string.

Usage

Are there any API changes?

  • The API has been changed.

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Feb 22, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@pissang pissang merged commit a302c0c into master Feb 23, 2021
@echarts-bot
Copy link

echarts-bot bot commented Feb 23, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang deleted the fix-14300 branch February 23, 2021 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants