Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(legend): make default legend more intuitive #14497

Merged
merged 24 commits into from Apr 7, 2021
Merged

feat(legend): make default legend more intuitive #14497

merged 24 commits into from Apr 7, 2021

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Mar 17, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Update default legend style so that the icons looks more intuitively like that of the series.

Fixed issues

Details

Before: What was the problem?

Legend for line series only have the color of the series, lacking itemStyle.borderWidth, itemStyle.borderColor, lineStyle.color, lineStyle.borderColor and etc.

After: How is it fixed in this PR?

Legend for line series looks more like that of the series.
emptyCircle has been changed to circle.

屏幕快照 2020-04-16 11 54 58

See test/legend-style.html for more info.

Usage

Are there any API changes?

  • The API has been changed.

Related test cases or examples to use the new APIs

test/legend-style.html

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

There was a PR #12444 before v5.0 and there was too much to be merged so I made this new PR based on v5.0 code base.

@echarts-bot
Copy link

echarts-bot bot commented Mar 17, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

@echarts-bot echarts-bot bot added PR: author is committer PR: awaiting doc Document changes is required for this PR. PR: awaiting review labels Mar 17, 2021
@Ovilia Ovilia marked this pull request as draft March 17, 2021 10:15
@Ovilia Ovilia marked this pull request as ready for review March 22, 2021 10:31
@Ovilia Ovilia changed the title WIP(legend): make default legend more intuitive feat(legend): make default legend more intuitive Mar 31, 2021
@pissang pissang merged commit 304685d into master Apr 7, 2021
2 checks passed
@echarts-bot
Copy link

echarts-bot bot commented Apr 7, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang deleted the fix-legend branch April 7, 2021 04:25
@pissang pissang added this to the 5.1.0 milestone Apr 9, 2021
Ovilia added a commit to apache/echarts-doc that referenced this pull request Apr 21, 2021
pissang added a commit to apache/echarts-doc that referenced this pull request Apr 21, 2021
@Ovilia Ovilia removed the PR: awaiting doc Document changes is required for this PR. label Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants