Skip to content

WIP(legend): more intuitive legend design#12444

Closed
Ovilia wants to merge 4 commits into
nextfrom
fix-legend-style
Closed

WIP(legend): more intuitive legend design#12444
Ovilia wants to merge 4 commits into
nextfrom
fix-legend-style

Conversation

@Ovilia
Copy link
Copy Markdown
Contributor

@Ovilia Ovilia commented Apr 16, 2020

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Update default legend style so that the icons looks more intuitively like that of the series.

Fixed issues

Details

Before: What was the problem?

Legend for line series only have the color of the series, lacking itemStyle.borderWidth, itemStyle.borderColor, lineStyle.color, lineStyle.borderColor and etc.

After: How is it fixed in this PR?

Legend for line series looks more like that of the series.
emptyCircle has been changed to circle.

屏幕快照 2020-04-16 11 54 58

See test/legend-style.html for more info.

Usage

Are there any API changes?

  • The API has been changed.

symbol of emptyCircle has been deprecated.

Related test cases or examples to use the new APIs

test/legend-style.html

TODO

  • Compat emptyCircle in other cases
  • Support other series (scatter series and etc.)

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link
Copy Markdown

echarts-bot Bot commented Apr 16, 2020

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@Ovilia Ovilia modified the milestones: 5.x, 5.1.0 Mar 1, 2021
@Ovilia Ovilia self-assigned this Mar 1, 2021
@Ovilia
Copy link
Copy Markdown
Contributor Author

Ovilia commented Mar 1, 2021

Too many conflicts. Close this PR and open a new open later.

@Ovilia Ovilia closed this Mar 1, 2021
Ovilia added a commit that referenced this pull request Mar 17, 2021
@pissang pissang deleted the fix-legend-style branch October 11, 2021 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant