Skip to content

chore: enhance github workflow#14722

Merged
pissang merged 6 commits into
masterfrom
enhance-workflow
Apr 20, 2021
Merged

chore: enhance github workflow#14722
pissang merged 6 commits into
masterfrom
enhance-workflow

Conversation

@pissang
Copy link
Copy Markdown
Contributor

@pissang pissang commented Apr 20, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

  1. Fix jest failes on node_modules/zrender
  2. Remove canvas from devDependency, which is always failed on install.
  3. Not install zrender from GitHub in the workflow. Always test on the version in the dependency.
  4. Add DTS check for earlier versions of TypeScript.
  5. Remove template string in the exported type. Avoid type error in the earlier versions of TypeScript. Typo in src/util/types.ts #14716
  6. Cache node_modules in the workflow to speedup the runner.

@echarts-bot
Copy link
Copy Markdown

echarts-bot Bot commented Apr 20, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@pissang pissang merged commit 23b7be1 into master Apr 20, 2021
@echarts-bot
Copy link
Copy Markdown

echarts-bot Bot commented Apr 20, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants