fix(MarkLineView): skip invalid markLine items that were normalized to undefined - #21716
Open
waterWang wants to merge 1 commit into
Open
fix(MarkLineView): skip invalid markLine items that were normalized to undefined#21716waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
…o undefined
When a markLine data entry is an empty object `{}`, markLineTransform
normalizes it to `[undefined, undefined, {...}]`. The subsequent
markLineFilter call then crashes on `item[0].coord` because item[0] is
undefined, causing no markLines to be rendered at all.
Fix: add a guard in markLineFilter to skip items where item[0] or item[1]
is undefined, matching the expected behavior described in the issue.
Fixes apache#21683
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: This message is shown because the PR description doesn't contain the document related template. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: skip invalid markLine items that were normalized to undefined
Issue
Fixes #21683
Problem
When a markLine data entry is an empty object
{}:markLineTransformnormalizes the empty object to[undefined, undefined, {...}].The subsequent
markLineFiltercall then crashes onitem[0].coordbecauseitem[0]isundefined,causing no markLines to be rendered at all — not even the valid ones.
Root Cause
In
markLineTransform, theelsebranch (invalid data) setsitemArray = [], but the function continues to constructnormalizedItemfromitemArray[0],itemArray[1],itemArray[2]— all of which areundefined. The filter then crashes on the undefined values.Fix
Added a guard in
markLineFilterto returnfalse(skip) whenitem[0]oritem[1]is undefined, which is the expected behavior: invalid entries should be silently skipped and valid entries should still render.Verification
{}entry is silently skipped without error