fix(toolbox): reset dataZoom active state on restore - #21720
Open
waterWang wants to merge 1 commit into
Open
Conversation
The toolbox dataZoom feature's `_isZoomActive` flag was not being reset when the `restore` action was dispatched. This caused the zoom toggle button to behave incorrectly after a chart restore: clicking "Enable drag zoom" would toggle off instead of on, because the stale `_isZoomActive` was still `true` from a previous zoom session. Fix: check for the `restore` payload type in `updateZoomBtnStatus` and reset `zoomActive` to `false`, ensuring the brush controller is properly disabled after restore and can be re-enabled cleanly on next activation. close apache#21661
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. To reviewers: If this PR is going to be described in the changelog in the future release, please make sure this PR has one of the following labels: This message is shown because the PR description doesn't contain the document related template. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Resets the toolbox dataZoom feature's active state when the "restore" action is dispatched, so the zoom toggle behaves correctly after a chart restore.
Fixed issues
Details
Before: What was the problem?
After clicking "Enable drag zoom" (which dispatches
takeGlobalCursorwithdataZoomSelectActive: true), zooming, then clicking the toolbox "Restore" button, the_isZoomActiveflag stayedtrue. Clicking "Enable drag zoom" again would toggle it off (because thezoomhandler computes!this._isZoomActive), leaving the feature in a broken state where the second zoom produces a wrong result.After: How does it behave after the fixing?
Added a check for the "restore" payload type in
updateZoomBtnStatus, resettingzoomActivetofalse. Now after restore the brush controller is properly disabled, and the next "Enable drag zoom" click correctly re-enables it, producing a correct zoom.close #21661