Skip to content

docs(#5337): add architecture-review evidence table for #5296 sub-issues - #5349

Merged
qqeasonchen merged 1 commit into
developfrom
fix/5337-evidence
Sep 8, 2026
Merged

docs(#5337): add architecture-review evidence table for #5296 sub-issues#5349
qqeasonchen merged 1 commit into
developfrom
fix/5337-evidence

Conversation

@qqeasonchen

Copy link
Copy Markdown
Contributor

What this PR does

Closes #5337 (Q1 production validation evidence + Q8 closure criteria for #5296 sub-issues).

This PR adds docs/architecture-review/evidence.md -- a single-source-of-truth evidence table that links every closed sub-issue of #5296 to:

  • the PR that landed the change,
  • the implementation commit on develop (squash hash),
  • the test files (JUnit / TCK) that exercise the change,
  • the test command to reproduce the result,
  • the CI run that observed the pass/fail (or current status if pending),
  • the backend + version under which the test runs,
  • the deployment topology (single / multi-instance / crash-recovery),
  • the observed result.

Coverage

19 PRs catalogued, of which:

7 reliability scenarios from #5337 Q1

# Scenario Primary evidence
1 RocketMQ 5 POP broker ACK barrier (duplicate ACKs / out-of-order) #5311 + #5336
2 RocketMQ 4 -- basic delivery ACKs (single + multi) #5311 + #5317
3 Kafka -- offset persistence (broker-ack / broker-ack-then-crash) #5311 + #5345
4 Crash recovery (kill mid-delivery, no double / no lost) #5311 + #5318
5 DLQ failure (exhaust retries -> durable DLQ) #5312
6 Cursor recovery (restart, per-subscriber cursor) #5311 + #5345
7 Multi-instance fencing (split-brain, stale partition owner) #5317 + #5318

All 7 scenarios have at least one MERGED PR with the test implementation.

Items moved to follow-up (per #5337 acceptance)

Current CI status (as of 2026-09-08 09:50 GMT+8)

A repository-level startup_failure is affecting every workflow that requires a GitHub-hosted runner since 2026-09-07 16:23 UTC. 65% of recent workflow runs are startup_failure. Last known successful push to develop was 2b0d7abb1 on 2026-09-03 02:18 UTC. Workflow file content is unchanged between the last successful and current failing runs (verified for architecture-guard.yml). This is a repository-level Actions registry / runner availability issue, not a code-introduced regression.

Acceptance

Co-authored-by: qqeasonchen qqeasonchen@gmail.com

Closes #5337 (Q1 production validation evidence + Q8 closure criteria).

Links every closed sub-issue of #5296 to its PR, squash-commit hash, test
files, test command, CI run, backend/version, deployment topology, and
observed result. The 7 reliability scenarios called out in #5337 (Q1)
are answered in the "Scenarios" section with concrete PR + test refs.

Status legend distinguishes MERGED (PR landed; CI on record before the
Actions platform outage) from OPEN-CI-startup_failure (PR open; CI
blocked by a repository-level runner availability issue affecting all
workflows since 2026-09-07 16:23 UTC). 19 PRs are catalogued, of which
16 are MERGED and 3 are OPEN-CI-startup_failure (#5345 / #5346 / #5348,
all blocked on the same platform issue).

Co-authored-by: qqeasonchen <qqeasonchen@gmail.com>

Retry-CI: Retry-CI-after-outage-1788836620
@qqeasonchen
qqeasonchen merged commit b08e591 into develop Sep 8, 2026
1 check passed
@qqeasonchen
qqeasonchen deleted the fix/5337-evidence branch September 8, 2026 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Architecture Review] Collect executable evidence and closure criteria for #5296 sub-issues

1 participant