fix: copy sheet-level read params to sheet holder - #1052
Merged
Conversation
locale, useScientificFormat and filedCacheLocation were not carried from the parameter sheet to the actual sheet, so setting them on the sheet builder silently fell back to the workbook-level value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed: #1051
Purpose of the pull request
ReadSheet.copyBasicParametercopied 12 of the 15 read parameters -locale,useScientificFormatandfiledCacheLocationwere missing, so a value set after.sheet(...)was dropped and the workbook-level value was silently applied insteadWhat's changed?
This adds the three missing copies, so all three now behave like
autoTrim,autoStrip,use1904windowingandheadRowNumber, which were already copied.Checklist