Skip to content

refactor: manage password handling in Excel processing#928

Merged
psxjoy merged 1 commit into
apache:mainfrom
psxjoy:fix_psxjoy_20260605
Jun 6, 2026
Merged

refactor: manage password handling in Excel processing#928
psxjoy merged 1 commit into
apache:mainfrom
psxjoy:fix_psxjoy_20260605

Conversation

@psxjoy

@psxjoy psxjoy commented Jun 5, 2026

Copy link
Copy Markdown
Member

Purpose of the pull request

Improve the lifecycle handling of POI encryption context in XLS read/write paths.

What's changed?

  • Scope encryption context setup to the XLS operations that require it.
  • Clear the context in finally after XLS sheet listing, parsing, and write protection.
  • Add regression assertions to verify the context is cleared after encrypted read/write flows.

Checklist

  • I have read the Contributor Guide.
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@pjfanning pjfanning left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@psxjoy
psxjoy merged commit 7fe23f0 into apache:main Jun 6, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants