fix: remove redundant buffer copy in IoUtils.toByteArray(InputStream)#963
Open
nkuprins wants to merge 1 commit into
Open
fix: remove redundant buffer copy in IoUtils.toByteArray(InputStream)#963nkuprins wants to merge 1 commit into
nkuprins wants to merge 1 commit into
Conversation
The finally block called output.toByteArray() and discarded the result. ByteArrayOutputStream.toByteArray() allocates a full copy of the internal buffer, so every call allocated the payload twice. ByteArrayOutputStream needs no closing, so the try/finally is removed entirely. Closes apache#952
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Closed: #952
What's changed?
IoUtils.toByteArray(InputStream)had afinallyblock callingoutput.toByteArray()and discarding the result.ByteArrayOutputStream.toByteArray()allocates a full copy of the internal buffer, so every call allocated the payload twice - a leftover from translating commons-io's try-with-resources version, where thefinallywould have beenoutput.close()(a no-op forByteArrayOutputStream).This removes the
try/finallyentirely.Testing
No behaviour change. Existing
IoUtilsTest(7 cases) passes unchanged.Checklist